idle-crafting: make choice of crafting job dependent on linked stockpiles. #1300
+179
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…linked stockpiles.
chdoc
force-pushed
the
idle-crafting
branch
from
9ac8050
to
d8c6cac
Compare
chdoc
changed the title
myk002
reviewed
Sep 13, 2024
| local function for_inputs(workshop, action) | ||
| if #workshop.profile.links.take_from_pile == 0 then | ||
| dfhack.error('workshop has no links') | ||
| else |
There was a problem hiding this comment.
you can turn the else into an end and save some indentation in the rest of the function. dfhack.error throws and does not allow the function to continue.
myk002
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.